Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I1010 embargo lease support #950

Merged
merged 2 commits into from
Apr 17, 2024
Merged

I1010 embargo lease support #950

merged 2 commits into from
Apr 17, 2024

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Apr 17, 2024 •
edited
Loading

Summary

Changes c/o PITT.

We are adding support to enable users to set embargo and lease rules from a CSV import.

Acceptance Criteria

  • As an admin user I can upload Embargo rules via a CSV through Bulkrax
  • CSV fields for Embargoes include:
    • Restricted To - this text field defines the visibility level during Embargo
    • Restricted Until - this date field defines the end date of the Embargo
    • Open To After Restriction - this text field defines the visibility level upon expiration of the
      Embargo
  • This has been contributed back to Bulkrax
  • This has been contributed back to Hyku

Sample CSV:

embargo-lease.csv

Screenshots / Video

The following works' embargo/lease rules were created by uploading the sample CSV.

Screenshot 2024-04-16 at 17-40-38 LEASE set via Bulkrax
Screenshot 2024-04-16 at 17-40-31 Show Entry __ Hyku
Screenshot 2024-04-16 at 17-40-27 EMBARGO set via Bulkrax
Screenshot 2024-04-16 at 17-40-19 Show Entry __ Hyku
Screenshot 2024-04-16 at 17-39-26 Show Importer __ Hyku

Raise error if model is not valid, which previously used to error out with:

*** NoMethodError Exception: undefined method `method_defined?' for nil:NilClass

Screenshot 2024-04-16 at 17-36-28 Show Entry __ Hyku

Expected Behavior

  • a user can specify embargo or lease rules on a CSV

Notes

TODO: Update bulkrax wiki with documentation once this gets merged

@ShanaLMoore
🎁 [i1010] - Add bulkrax support for Embargo and Lease Rules
04e599e 
In this commit, user are able to import embargo and lease rules via CSV headers.

Issue:
- scientist-softserv/palni-palci#1010
@ShanaLMoore ShanaLMoore added the minor-ver for release notes label Apr 17, 2024
@ShanaLMoore ShanaLMoore marked this pull request as ready for review April 17, 2024 16:09
orangewolf
orangewolf approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems great @ShanaLMoore and very likely to work across Valkyrie / AF

@ShanaLMoore ShanaLMoore merged commit 855ce39 into main Apr 17, 2024
6 checks passed
@ShanaLMoore ShanaLMoore deleted the i1010-embargo-lease-support branch April 17, 2024 16:49
@ShanaLMoore ShanaLMoore mentioned this pull request Apr 17, 2024
Closed
2 tasks
@kerchner
Copy link
Contributor

😃 👍 Very happy to see this work. We generally embargo just the FileSets but not the parent work, so I assume that by specifying the parent work and its FileSets on separate lines of the CSV, that this will enable embargoing each piece separately

@ShanaLMoore ShanaLMoore mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyf jeremyf jeremyf approved these changes

@orangewolf orangewolf orangewolf approved these changes

Assignees
No one assigned
Labels
minor-ver for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShanaLMoore @kerchner @jeremyf @orangewolf